From 7e8015645c0d9b6263344cb6b04087962d2c851e Mon Sep 17 00:00:00 2001
From: Mo Firouz <mo@heroiclabs.com>
Date: Mon, 31 Jul 2017 11:17:20 +0100
Subject: [PATCH] Slight improvement in storage update pipeline

---
 server/pipeline_storage.go | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/server/pipeline_storage.go b/server/pipeline_storage.go
index f43b78740..d54fd874c 100644
--- a/server/pipeline_storage.go
+++ b/server/pipeline_storage.go
@@ -170,8 +170,8 @@ func (p *pipeline) storageUpdate(logger *zap.Logger, session *session, envelope
 		return
 	}
 
-	keyUpdates := make([]*StorageKeyUpdate, 0)
-	for _, update := range incoming.Updates {
+	keyUpdates := make([]*StorageKeyUpdate, len(incoming.Updates))
+	for i, update := range incoming.Updates {
 		keyUpdate := &StorageKeyUpdate{
 			PermissionRead:  int64(update.PermissionRead),
 			PermissionWrite: int64(update.PermissionWrite),
@@ -184,8 +184,8 @@ func (p *pipeline) storageUpdate(logger *zap.Logger, session *session, envelope
 			},
 		}
 
-		jsonOps := make([]map[string]*json.RawMessage, 0)
-		for _, op := range update.Ops {
+		jsonOps := make([]map[string]*json.RawMessage, len(update.Ops))
+		for i, op := range update.Ops {
 			opString := ""
 			switch TStorageUpdate_StorageUpdate_UpdateOp_UpdateOpCode(op.Op) {
 			case ADD:
@@ -232,7 +232,7 @@ func (p *pipeline) storageUpdate(logger *zap.Logger, session *session, envelope
 				"conditional": &conditional,
 				"assert":      &assert,
 			}
-			jsonOps = append(jsonOps, jsonOp)
+			jsonOps[i] = jsonOp
 		}
 
 		p, err := jsonpatch.NewExtendedPatch(jsonOps)
@@ -242,7 +242,7 @@ func (p *pipeline) storageUpdate(logger *zap.Logger, session *session, envelope
 			return
 		}
 		keyUpdate.Patch = p
-		keyUpdates = append(keyUpdates, keyUpdate)
+		keyUpdates[i] = keyUpdate
 	}
 
 	updatedKeys, errCode, err := StorageUpdate(logger, p.db, session.userID, keyUpdates)
-- 
GitLab