Unverified Commit 74916aa9 authored by Simon Esposito's avatar Simon Esposito Committed by GitHub
Browse files

Fix JavaScript runtime hooks not being invoked correctly (#553) 

Fix console UI leaderboard delete
Fix issues with js runtime storgeWrite and notificationsSend functions.
parent 80831bfb

CHANGELOG.md

+3 −0
Original line number Diff line number Diff line
@@ -4,6 +4,9 @@ All notable changes to this project are documented below. 
The format is based on [keep a changelog](http://keepachangelog.com) and this project uses [semantic versioning](http://semver.org).



## [Unreleased]

### Fixed

- Fix an issue that prevented the JavaScript runtime hooks to be invoked correctly.

- Fix the delete button not working in the console leaderboard listing.



## [3.1.0] - 2021-02-04

### Added

console/a_console-packr.go

+49 −49

File changed.

Preview size limit exceeded, changes collapsed.

console/console.pb.go

+255 −254

File changed.

Preview size limit exceeded, changes collapsed.

console/console.pb.gw.go

+15 −13
Original line number Diff line number Diff line
@@ -813,10 +813,6 @@ func local_request_Console_DeleteLeaderboard_0(ctx context.Context, marshaler ru 


}



var (

	filter_Console_DeleteLeaderboardRecord_0 = &utilities.DoubleArray{Encoding: map[string]int{"id": 0}, Base: []int{1, 1, 0}, Check: []int{0, 1, 2}}

)



func request_Console_DeleteLeaderboardRecord_0(ctx context.Context, marshaler runtime.Marshaler, client ConsoleClient, req *http.Request, pathParams map[string]string) (proto.Message, runtime.ServerMetadata, error) {

	var protoReq DeleteLeaderboardRecordRequest

	var metadata runtime.ServerMetadata
@@ -838,11 +834,14 @@ func request_Console_DeleteLeaderboardRecord_0(ctx context.Context, marshaler ru 
		return nil, metadata, status.Errorf(codes.InvalidArgument, "type mismatch, parameter: %s, error: %v", "id", err)

	}



	if err := req.ParseForm(); err != nil {

		return nil, metadata, status.Errorf(codes.InvalidArgument, "%v", err)

	val, ok = pathParams["owner_id"]

	if !ok {

		return nil, metadata, status.Errorf(codes.InvalidArgument, "missing parameter %s", "owner_id")

	}

	if err := runtime.PopulateQueryParameters(&protoReq, req.Form, filter_Console_DeleteLeaderboardRecord_0); err != nil {

		return nil, metadata, status.Errorf(codes.InvalidArgument, "%v", err)



	protoReq.OwnerId, err = runtime.String(val)

	if err != nil {

		return nil, metadata, status.Errorf(codes.InvalidArgument, "type mismatch, parameter: %s, error: %v", "owner_id", err)

	}



	msg, err := client.DeleteLeaderboardRecord(ctx, &protoReq, grpc.Header(&metadata.HeaderMD), grpc.Trailer(&metadata.TrailerMD))
@@ -871,11 +870,14 @@ func local_request_Console_DeleteLeaderboardRecord_0(ctx context.Context, marsha 
		return nil, metadata, status.Errorf(codes.InvalidArgument, "type mismatch, parameter: %s, error: %v", "id", err)

	}



	if err := req.ParseForm(); err != nil {

		return nil, metadata, status.Errorf(codes.InvalidArgument, "%v", err)

	val, ok = pathParams["owner_id"]

	if !ok {

		return nil, metadata, status.Errorf(codes.InvalidArgument, "missing parameter %s", "owner_id")

	}

	if err := runtime.PopulateQueryParameters(&protoReq, req.Form, filter_Console_DeleteLeaderboardRecord_0); err != nil {

		return nil, metadata, status.Errorf(codes.InvalidArgument, "%v", err)



	protoReq.OwnerId, err = runtime.String(val)

	if err != nil {

		return nil, metadata, status.Errorf(codes.InvalidArgument, "type mismatch, parameter: %s, error: %v", "owner_id", err)

	}



	msg, err := server.DeleteLeaderboardRecord(ctx, &protoReq)
@@ -4561,7 +4563,7 @@ var ( 


	pattern_Console_DeleteLeaderboard_0 = runtime.MustPattern(runtime.NewPattern(1, []int{2, 0, 2, 1, 2, 2, 1, 0, 4, 1, 5, 3}, []string{"v2", "console", "leaderboard", "id"}, ""))



	pattern_Console_DeleteLeaderboardRecord_0 = runtime.MustPattern(runtime.NewPattern(1, []int{2, 0, 2, 1, 2, 2, 1, 0, 4, 1, 5, 3}, []string{"v2", "console", "leaderboard", "id"}, ""))

	pattern_Console_DeleteLeaderboardRecord_0 = runtime.MustPattern(runtime.NewPattern(1, []int{2, 0, 2, 1, 2, 2, 1, 0, 4, 1, 5, 3, 2, 4, 1, 0, 4, 1, 5, 5}, []string{"v2", "console", "leaderboard", "id", "owner", "owner_id"}, ""))



	pattern_Console_DeleteUser_0 = runtime.MustPattern(runtime.NewPattern(1, []int{2, 0, 2, 1, 2, 2}, []string{"v2", "console", "user"}, ""))

console/console.proto

+1 −1
Original line number Diff line number Diff line
@@ -157,7 +157,7 @@ service Console { 


  // Delete leaderboard record

  rpc DeleteLeaderboardRecord (DeleteLeaderboardRecordRequest) returns (google.protobuf.Empty) {

    option (google.api.http).delete = "/v2/console/leaderboard/{id}";

    option (google.api.http).delete = "/v2/console/leaderboard/{id}/owner/{owner_id}";

  }



  // Delete console user.