From 4ce767230523e84f6a181c6b0ce943c1e59d626f Mon Sep 17 00:00:00 2001 From: Andrei Mihu Date: Thu, 3 Oct 2019 16:15:25 +0100 Subject: [PATCH] Correct error code for group creation name conflicts. --- CHANGELOG.md | 1 + server/api_group.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d067b939a..dda097aee 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,7 @@ The format is based on [keep a changelog](http://keepachangelog.com) and this pr ## [Unreleased] ### Changed - Default runtime HTTP key value is no longer the same as the default Server key value. +- Group create now returns HTTP 409 Conflict/GRPC Code 6 when group name is already in use. ## [2.7.0] - 2019-09-11 ### Added diff --git a/server/api_group.go b/server/api_group.go index c5fa3e12e..2c48b1c65 100644 --- a/server/api_group.go +++ b/server/api_group.go @@ -65,7 +65,7 @@ func (s *ApiServer) CreateGroup(ctx context.Context, in *api.CreateGroupRequest) group, err := CreateGroup(ctx, s.logger, s.db, userID, userID, in.GetName(), in.GetLangTag(), in.GetDescription(), in.GetAvatarUrl(), "", in.GetOpen(), maxCount) if err != nil { if err == ErrGroupNameInUse { - return nil, status.Error(codes.InvalidArgument, "Group name is in use.") + return nil, status.Error(codes.AlreadyExists, "Group name is in use.") } return nil, status.Error(codes.Internal, "Error while trying to create group.") } -- GitLab