Unverified Commit 4abf684c authored by Fernando Takagi's avatar Fernando Takagi Committed by GitHub
Browse files

Allow StorageWriteRequest to accept undefined userId value in TypeScript to... 

Allow StorageWriteRequest to accept undefined userId value in TypeScript to create a system owned object (#820)
parent 326c9af0

go.mod

+1 −1
Changes for go.mod: 1 added line, 1 removed line.
Original line number Diff line number Diff line
@@ -13,7 +13,7 @@ require ( 
	github.com/gorilla/mux v1.8.0

	github.com/gorilla/websocket v1.4.2

	github.com/grpc-ecosystem/grpc-gateway/v2 v2.7.0

	github.com/heroiclabs/nakama-common v1.22.0

	github.com/heroiclabs/nakama-common v1.22.1-0.20220328201422-bed57ba110d8

	github.com/jackc/pgconn v1.10.0

	github.com/jackc/pgerrcode v0.0.0-20201024163028-a0d42d470451

	github.com/jackc/pgtype v1.8.1

go.sum

+2 −0
Changes for go.sum: 2 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -257,6 +257,8 @@ github.com/hashicorp/golang-lru v0.5.1/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ 
github.com/hashicorp/hcl v1.0.0/go.mod h1:E5yfLk+7swimpb2L/Alb/PJmXilQ/rhwaUYs4T20WEQ=

github.com/heroiclabs/nakama-common v1.22.0 h1:8poRz024S6gedi4mlOHEHPayTKtjh1DKsSZVF0uJpyU=

github.com/heroiclabs/nakama-common v1.22.0/go.mod h1:WF4YG46afwY3ibzsXnkt3zvhQ3tBY03IYeU7xSLr8HE=

github.com/heroiclabs/nakama-common v1.22.1-0.20220328201422-bed57ba110d8 h1:2gUIdPre/Q57HUwd+GtbSc3CucU/wqgEVpmIF5tiSto=

github.com/heroiclabs/nakama-common v1.22.1-0.20220328201422-bed57ba110d8/go.mod h1:WF4YG46afwY3ibzsXnkt3zvhQ3tBY03IYeU7xSLr8HE=

github.com/huandu/xstrings v1.3.2/go.mod h1:y5/lhBue+AyNmUVz9RLU9xbLR0o4KIIExikq4ovT0aE=

github.com/ianlancetaylor/demangle v0.0.0-20181102032728-5e5cf60278f6/go.mod h1:aSSvb/t6k1mPoxDqO4vJh6VOCGPwU4O0C2/Eqndh1Sc=

github.com/imdario/mergo v0.3.11/go.mod h1:jmQim1M+e3UYxmgPu/WyfjB3N3VflVyUjjjwH0dnCYA=

server/runtime_javascript_nakama.go

+4 −0
Changes for server/runtime_javascript_nakama.go: 4 added lines, 0 removed lines.
Original line number Diff line number Diff line
@@ -4166,6 +4166,9 @@ func (n *runtimeJavascriptNakamaModule) storageWrite(r *goja.Runtime) func(goja. 
			writeOp.Key = key



			userIDIn, ok := dataMap["userId"]

			if userIDIn == nil {

				userID = uuid.Nil

			} else {

				userIDStr, ok := userIDIn.(string)

				if !ok {

					panic(r.NewTypeError("expects 'userId' value to be a string"))
@@ -4175,6 +4178,7 @@ func (n *runtimeJavascriptNakamaModule) storageWrite(r *goja.Runtime) func(goja. 
				if err != nil {

					panic(r.NewTypeError("expects 'userId' value to be a valid id"))

				}

			}



			valueIn, ok := dataMap["value"]

			valueMap, ok := valueIn.(map[string]interface{})