Commit 420ad8b2 authored by Andrei Mihu's avatar Andrei Mihu
Browse files

Allow Console API requests to return results above default size limit.

parent 7443bb89

CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -10,6 +10,7 @@ The format is based on [keep a changelog](http://keepachangelog.com) and this pr 
### Changed

- Default runtime HTTP key value is no longer the same as the default Server key value.

- Group create now returns HTTP 409 Conflict/GRPC Code 6 when group name is already in use.

- Allow Console API requests to return results above default size limit.



### Fixed

- Correctly handle errors when concurrently writing new storage objects.

server/console.go

+1 −11
Original line number Diff line number Diff line
@@ -96,17 +96,7 @@ func StartConsoleServer(logger *zap.Logger, startupLogger *zap.Logger, db *sql.D 


	ctx := context.Background()

	grpcGateway := runtime.NewServeMux()

	dialAddr := fmt.Sprintf("127.0.0.1:%d", config.GetConsole().Port-3)

	if config.GetConsole().Address != "" {

		dialAddr = fmt.Sprintf("%v:%d", config.GetConsole().Address, config.GetConsole().Port-3)

	}

	dialOpts := []grpc.DialOption{

		//TODO (mo, zyro): Do we need to pass the statsHandler here as well?

		grpc.WithDefaultCallOptions(grpc.MaxCallSendMsgSize(int(config.GetConsole().MaxMessageSizeBytes))),

		grpc.WithInsecure(),

	}



	if err := console.RegisterConsoleHandlerFromEndpoint(ctx, grpcGateway, dialAddr, dialOpts); err != nil {

	if err := console.RegisterConsoleHandlerServer(ctx, grpcGateway, s); err != nil {

		startupLogger.Fatal("Console server gateway registration failed", zap.Error(err))

	}