Commit 3ec17765 authored by Andrei Mihu's avatar Andrei Mihu
Browse files

Improve validation of count multiple matchmaker parameter.

parent 2bf7298b

CHANGELOG.md

+2 −1
Original line number Diff line number Diff line
@@ -8,7 +8,8 @@ The format is based on [keep a changelog](http://keepachangelog.com) and this pr 
- Add subscription validation APIs and runtime functions for Google and Apple.



### Changed

- Improved runtime handling of non-persisted purchases and subscriptions.

- Improve runtime handling of non-persisted purchases and subscriptions.

- Improve validation of count multiple matchmaker parameter.



## [3.12.0] - 2022-05-22

### Added

server/pipeline_matchmaker.go

+0 −14
Original line number Diff line number Diff line
@@ -54,20 +54,6 @@ func (p *Pipeline) matchmakerAdd(logger *zap.Logger, session Session, envelope * 
			}}}, true)

			return false, nil

		}

		if countMultiple < minCount {

			session.Send(&rtapi.Envelope{Cid: envelope.Cid, Message: &rtapi.Envelope_Error{Error: &rtapi.Error{

				Code:    int32(rtapi.Error_BAD_INPUT),

				Message: "Invalid count multiple, must be >= minimum count",

			}}}, true)

			return false, nil

		}

		if countMultiple > maxCount {

			session.Send(&rtapi.Envelope{Cid: envelope.Cid, Message: &rtapi.Envelope_Error{Error: &rtapi.Error{

				Code:    int32(rtapi.Error_BAD_INPUT),

				Message: "Invalid count multiple, must be <= maximum count",

			}}}, true)

			return false, nil

		}

		if minCount%countMultiple != 0 {

			session.Send(&rtapi.Envelope{Cid: envelope.Cid, Message: &rtapi.Envelope_Error{Error: &rtapi.Error{

				Code:    int32(rtapi.Error_BAD_INPUT),

server/pipeline_party.go

+0 −14
Original line number Diff line number Diff line
@@ -428,20 +428,6 @@ func (p *Pipeline) partyMatchmakerAdd(logger *zap.Logger, session Session, envel 
			}}}, true)

			return false, nil

		}

		if countMultiple < minCount {

			session.Send(&rtapi.Envelope{Cid: envelope.Cid, Message: &rtapi.Envelope_Error{Error: &rtapi.Error{

				Code:    int32(rtapi.Error_BAD_INPUT),

				Message: "Invalid count multiple, must be >= minimum count",

			}}}, true)

			return false, nil

		}

		if countMultiple > maxCount {

			session.Send(&rtapi.Envelope{Cid: envelope.Cid, Message: &rtapi.Envelope_Error{Error: &rtapi.Error{

				Code:    int32(rtapi.Error_BAD_INPUT),

				Message: "Invalid count multiple, must be <= maximum count",

			}}}, true)

			return false, nil

		}

		if minCount%countMultiple != 0 {

			session.Send(&rtapi.Envelope{Cid: envelope.Cid, Message: &rtapi.Envelope_Error{Error: &rtapi.Error{

				Code:    int32(rtapi.Error_BAD_INPUT),