Unverified Commit 235bed3b authored by Simon Esposito's avatar Simon Esposito Committed by GitHub
Browse files

Support purchases-not-null-uid.sql migration on crdb. (#992) 

Fix purchases-not-null-uid.sql migration up for crdb.
The migration failed because pg and crdb name fk constraints differently.
Set the migration as notransaction because crdb fails to apply it if
multiple alter table statements are made on the same fk within the
same transaction.
parent 2b249ce3

migrate/sql/20230222172540-purchases-not-null-uid.sql→migrate/sql/20230222172540-purchases-not-null-uid-1.sql

+8 −32
Original line number Diff line number Diff line
@@ -15,47 +15,23 @@ 
 */



-- +migrate Up

-- This migration is split in two files due to the following CRDB limitation

-- https://stackoverflow.com/questions/68803747/encapsulating-a-drop-and-add-constraint-in-a-transaction

ALTER TABLE purchase

    DROP CONSTRAINT purchase_user_id_fkey;

    DROP CONSTRAINT IF EXISTS purchase_user_id_fkey,

    DROP CONSTRAINT IF EXISTS fk_user_id_ref_users;

ALTER TABLE subscription

    DROP CONSTRAINT subscription_user_id_fkey;

    DROP CONSTRAINT IF EXISTS subscription_user_id_fkey,

    DROP CONSTRAINT IF EXISTS fk_user_id_ref_users;



UPDATE purchase

    SET user_id = '00000000-0000-0000-0000-000000000000' WHERE user_id IS NULL;

UPDATE subscription

    SET user_id = '00000000-0000-0000-0000-000000000000' WHERE user_id IS NULL;



ALTER TABLE purchase

    ALTER COLUMN user_id SET NOT NULL;

ALTER TABLE purchase

    ALTER COLUMN user_id SET DEFAULT '00000000-0000-0000-0000-000000000000';



ALTER TABLE subscription

    ALTER COLUMN user_id SET NOT NULL;

ALTER TABLE subscription

    ALTER COLUMN user_id SET DEFAULT '00000000-0000-0000-0000-000000000000';



ALTER TABLE purchase

    ADD CONSTRAINT purchase_user_id_fkey FOREIGN KEY (user_id) REFERENCES users (id) ON DELETE SET DEFAULT;

ALTER TABLE subscription

    ADD CONSTRAINT subscription_user_id_fkey FOREIGN KEY (user_id) REFERENCES users (id) ON DELETE SET DEFAULT;



-- +migrate Down

ALTER TABLE purchase

    DROP CONSTRAINT purchase_user_id_fkey;

ALTER TABLE subscription

    DROP CONSTRAINT subscription_user_id_fkey;



ALTER TABLE purchase

    ALTER COLUMN user_id DROP DEFAULT;

ALTER TABLE purchase

    ALTER COLUMN user_id DROP NOT NULL;



ALTER TABLE subscription

    ALTER COLUMN user_id DROP DEFAULT;

ALTER TABLE subscription

    ALTER COLUMN user_id DROP NOT NULL;



-- This migration is split in two files due to the following CRDB limitation

-- https://stackoverflow.com/questions/68803747/encapsulating-a-drop-and-add-constraint-in-a-transaction

UPDATE purchase

    SET user_id = NULL WHERE user_id = '00000000-0000-0000-0000-000000000000';

UPDATE subscription

migrate/sql/20230222172540-purchases-not-null-uid-2.sql

0 → 100644
+47 −0
Original line number Diff line number Diff line 
/*

 * Copyright 2021 The Nakama Authors

 *

 * Licensed under the Apache License, Version 2.0 (the "License");

 * you may not use this file except in compliance with the License.

 * You may obtain a copy of the License at

 *

 * http://www.apache.org/licenses/LICENSE-2.0

 *

 * Unless required by applicable law or agreed to in writing, software

 * distributed under the License is distributed on an "AS IS" BASIS,

 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

 * See the License for the specific language governing permissions and

 * limitations under the License.

 */



-- +migrate Up

-- This migration is split in two files due to the following CRDB limitation

-- https://stackoverflow.com/questions/68803747/encapsulating-a-drop-and-add-constraint-in-a-transaction

ALTER TABLE purchase

    ALTER COLUMN user_id SET NOT NULL,

    ALTER COLUMN user_id SET DEFAULT '00000000-0000-0000-0000-000000000000';

ALTER TABLE subscription

    ALTER COLUMN user_id SET NOT NULL,

    ALTER COLUMN user_id SET DEFAULT '00000000-0000-0000-0000-000000000000';



ALTER TABLE purchase

    ADD CONSTRAINT purchase_user_id_fkey FOREIGN KEY (user_id) REFERENCES users (id) ON DELETE SET DEFAULT;

ALTER TABLE subscription

    ADD CONSTRAINT subscription_user_id_fkey FOREIGN KEY (user_id) REFERENCES users (id) ON DELETE SET DEFAULT;



-- +migrate Down

-- This migration is split in two files due to the following CRDB limitation

-- https://stackoverflow.com/questions/68803747/encapsulating-a-drop-and-add-constraint-in-a-transaction

ALTER TABLE purchase

    DROP CONSTRAINT IF EXISTS purchase_user_id_fkey,

    DROP CONSTRAINT IF EXISTS fk_user_id_ref_users;

ALTER TABLE subscription

    DROP CONSTRAINT IF EXISTS subscription_user_id_fkey,

    DROP CONSTRAINT IF EXISTS fk_user_id_ref_users;



ALTER TABLE purchase

    ALTER COLUMN user_id DROP DEFAULT,

    ALTER COLUMN user_id DROP NOT NULL;

ALTER TABLE subscription

    ALTER COLUMN user_id DROP DEFAULT,

    ALTER COLUMN user_id DROP NOT NULL;