Commit 1fc62a9a authored by Andrei Mihu's avatar Andrei Mihu
Browse files

Handle leaderboard deletes shortly before a scheduled reset.

parent ef30c50f

CHANGELOG.md

+1 −0
Original line number Diff line number Diff line
@@ -14,6 +14,7 @@ The format is based on [keep a changelog](http://keepachangelog.com) and this pr 
### Fixed

- Handle updates during leaderboard schedule reset window.

- Ensure the matchmaker cannot match together tickets from the same session.

- Handle leaderboard deletes shortly before a scheduled reset.



## [2.6.0] - 2019-07-01

### Added

server/leaderboard_scheduler.go

+8 −1
Original line number Diff line number Diff line
@@ -290,7 +290,10 @@ WHERE id = $1` 
		row := ls.db.QueryRowContext(ls.ctx, query, id)

		tournament, err := parseTournament(row, t)

		if err != nil {

			if err != sql.ErrNoRows {

				// Do not log if tournament was deleted before it reached the scheduler here.

				ls.logger.Error("Error retrieving tournament to invoke end callback", zap.Error(err), zap.String("id", id))

			}

			continue

		}
@@ -333,6 +336,10 @@ func (ls *LocalLeaderboardScheduler) invokeExpiryElapse(t time.Time, ids []strin 
	// Process the current set of leaderboard and tournament resets.

	for _, id := range ids {

		leaderboardOrTournament := ls.cache.Get(id)

		if leaderboardOrTournament == nil {

			// Cached entry was deleted before it reached the scheduler here.

			continue

		}

		if leaderboardOrTournament.IsTournament() {

			// Tournament, fetch most up to date info for size etc.

			// Some processing is needed even if there is no runtime callback registered for tournament reset.