Commit da00671e authored by Hordur Freyr Yngvason's avatar Hordur Freyr Yngvason
Browse files

fix: add default ROLLOUT_RESOURCE_TYPE=deployment 

Needing to specify `ROLLOUT_RESOURCE_TYPE` is an obscure implementation
detail that most user should not need to care about. We don't even have
built-in support for other types, so we should not force users to set
it.

This is especially relevant to users who include
`Jobs/Deploy.gitlab-ci.yml` instead of `Auto-DevOps.gitlab-ci.yml`.
parent 3b4a4096

.gitlab/ci/test.gitlab-ci.yml

+0 −1
Original line number Diff line number Diff line
@@ -266,7 +266,6 @@ test-deploy: 
    CI_PROJECT_VISIBILITY: public

    KUBE_NAMESPACE: default

    KUBE_INGRESS_BASE_DOMAIN: example.com

    ROLLOUT_RESOURCE_TYPE: deployment

    POSTGRES_USER: user

    POSTGRES_PASSWORD: testing-password

    POSTGRES_ENABLED: "true"

src/bin/auto-deploy

+1 −0
Original line number Diff line number Diff line
@@ -10,6 +10,7 @@ export POSTGRESQL_RELEASE_NAME="${RELEASE_NAME}-postgresql" 
export POSTGRES_VERSION="${POSTGRES_VERSION:-"9.6.16"}"

export ASSETS_DIR='/assets'

export ASSETS_CHART_DIR="${ASSETS_DIR}/auto-deploy-app"

export ROLLOUT_RESOURCE_TYPE="${ROLLOUT_RESOURCE_TYPE:-deployment}"



function check_kube_domain() {

  if [[ -z "$KUBE_INGRESS_BASE_DOMAIN" ]]; then